-
Notifications
You must be signed in to change notification settings - Fork 121
[Local Catalog] Incremental sync: remote sync #16102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…All function in `POSCatalogFullSyncService`.
…sts. TODO: figure out a better way to delete existing product/variation images/attributes.
Modules/Tests/YosemiteTests/Tools/POS/POSCatalogFullSyncServiceTests.swift
Outdated
Show resolved
Hide resolved
|
|
Modules/Sources/Yosemite/Tools/POS/POSCatalogPersistenceService.swift
Outdated
Show resolved
Hide resolved
| siteID: siteID, | ||
| path: path, | ||
| parameters: parameters, | ||
| availableAsRESTRequest: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding availableAsRESTRequest: true as an oversight from the previous remote implementation.
joshheald
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, works well
|
Tested full sync integration with the latest trunk, merging now. |

Closes WOOMOB-1297
Summary
This PR introduces
POSCatalogIncrementalSyncServicefor incremental sync by only fetching products and variations modified since the last full/incremental sync. Only the remote sync is implemented in this PR, persistence is in #16106 to make reviews easier.Key Changes
Steps to reproduce
Just CI is sufficient, as the full/incremental services aren't integrated with the app yet.
Testing information
I tested that full sync worked as before, and incremental sync worked after a full sync for a big site:
If the full sync integration is merged, I will test the incremental sync with debug code after full sync integration is in trunk.
RELEASE-NOTES.txtif necessary.